Affinity Photo crop removes more than requested

[wlorentz]

After I crop tool to straighten an image in the Develop persona, pressing the Develop button results in the image in the Photo persona being more tightly cropped than what was shown in the Develop persona.

1. Application: Affinity Photo
2. Version: 2.3.0
3. Reproducible in many photos from both my Canon and Hasselblad cameras
4. Cannot test in a new document because it requires the Develop persona

• Operating system: macOS Sonoma 14.1.1
• Hardware acceleration on: Apple M1 Pro (Metal)

 

Screenshot of an image in the Develop persona. Note the right foot of the woman in the bottom right of the photo is completely visible:

 

Screenshot after pressing Develop and switching to the Photo persona.  Note that the woman's foot is gone, and the northwest and southeast corners of the image have been removed.  It's as if switching to Photo executes the Crop command again, even though the image was already cropped in Develop.

 

Edited December 2, 2023 by wlorentz

[NotMyFault]

Can you upload one example RAW file?

The crop function in Photo is non-destructive. So it will never cut off any parts, unless you use rasterize and trim after crop.

Can you please add screenshots of

• your development assistant settings, specifically Serif RAW vs. Apple RAW
• the lens correction tab in Develop Persona

[wlorentz]

On 12/2/2023 at 10:10 AM, NotMyFault said:

Can you upload one example RAW file?

The crop function in Photo is non-destructive. So it will never cut off any parts, unless you use rasterize and trim after crop.

Can you please add screenshots of

• your development assistant settings, specifically Serif RAW vs. Apple RAW
• the lens correction tab in Develop Persona

I do not do any rasterizing.  All I do is crop in Develop, and when I push the Develop button, it chops off extra parts of the image.

I have attached a video of this happening.  It shows an image about to be cropped in the Develop persona.  Watch the top left of the photograph after I press "Develop."  The corner is cut off.

I have also attached the source file.

 

 

14 West Randolph - Chicago, Illinois - November 27, 2009 - 002.CR2

 

[NotMyFault]

It seems you are rotating  the crop area before applying develop. The curser is changed to rotation arrow.

I would suggest to use rotation from lens panel.

Never the less, when you activate the move tool after develop I assume all layer content is still there - you can see the blue outline around the layer edge. Only the cropped area has bee shifted to the left, leading to a transparent area top right. Again, nothing has been cut off. 
I agree that the cropped area differs in position from what is expected.

unfortunatly, I’m unable to reproduce. Can you explain in more detail how do you set the cropped area, and if you actually use rotation while cropping ? If not, why is the rotation curser shown?

[NotMyFault]

Actually i can confirm (on iPad) that the cropped area slips in case you rotate the crop before develop. 

Again, i advise to use rotate from lens correction panel instead rotation by crop as workaround. I

[loukash]

17 hours ago, wlorentz said:

The corner is cut off.

I have also attached the source file.

Your image works for me: no cut-off corners using the Crop tool as seen in your screencast.

However, APh v2 sometimes has redraw glitches. The fix is to briefly zoom in and out so that the display can redraw. Perhaps it's just that?

[wlorentz]

I think I've narrowed down the offending behavior.  It seems that after cropping in the Develop mode, when switching to the Photo mode, Affinity Photo crops a second time based on the dimensions specified for the previous crop action.  This shouldn't happen, because the photo was already cropped in Develop.

 

Step 1: Start with a raw photo imported into Affinity Photo

 

Step 2: Select the crop tool to crop and rotate the photograph.  Note how in this photograph, the bottom of the default crop is against the bottom of the ice cream stand on the right, but there is still plenty of image below that we want to preserve.

 

Step 3: Rotate the image as desired, and adjust the crop mask to include the bottom of the photograph which we want to preserve.

 

Step 4: Execute the crop.  Note how in the bottom right of the image, the spoons are not touching the edge of the photograph.

 

Step 5: Press "Develop."  When the image is developed, the crop command is executed again with the same size and rotation as the previous crop.  Note that the spoons in the bottom right of the photograph are now at the edge of the image where the corner has been cut off.

 

There's something in the process of switching from Develop mode to Photo mode that unnecessarily activates the previous crop action again, thus clipping off the corners of images that are already rotated and cropped in Develop mode.  

The Photo mode should not crop images without being told to do so by the user.

 

 

Edited December 24, 2023 by wlorentz

[NotMyFault]

Steps to reproduce

1. Open any RAW file
2. use vertical lens correction, set to minus 43
3. crop to a certain degree, and use a rotation.
4. you can already spot that the automatic „crop to opaque“ is incorrectly cutting off one of the corners.
5. Apply crop
6. Apply develop
7. now the crop gets applied in the wrong place, shifted to one side. This leads to corners of the original RAW getting exposed with transparent areas outside the original RAW.

nothing is cut of, but the cropped area is shifted to the edge 

 

[Hangman]

Thanks @NotMyFault,

1 hour ago, NotMyFault said:

nothing is cut of, but the cropped area is shifted to the edge

For clarity, we are talking about opening a straight-out-of-camera RAW file in the Develop Persona right? If so then I've not been able to replicate the issue so I may be misunderstanding one of the steps...

 

Source Image | Crop and Rotate | Developed Image

 

[NotMyFault]

1 hour ago, Hangman said:

For clarity, we are talking about opening a straight-out-of-camera RAW file in the Develop Persona right?

Yes, absolutely.

the issue occurs only in case of certain trigger conditions. Today i tried to screen record but failed to reproduce it in a short usable video. It occurs, but the process was far to long.

trigger combination:

• raw file (cr2) with supported lens
• vertical lens correction (that is missing in your video)
• crop with rotation

you may need several tries 

[Hangman]

48 minutes ago, NotMyFault said:

• vertical lens correction (that is missing in your video)

This wasn't in your original set of instructions but I've just updated my post to reflect this, though I'm still not experiencing the issue but I'll keep trying...

Is it unique to .cr2 files, I've tested the .cr2 file @wlorentz uploaded and likewise can't replicate the issue using that file either...

 

[NotMyFault]

the screen recording shows the exact steps. 

[Hangman]

There appears to be something odd going on at the point where you rotate the image (28 secs)... if you look at the top edge of the image as you rotate it in your screen recording it always remains perfectly horizontal instead of rotating which is what I see when I rotate the image. I don't know if it's a screen redraw issue...

Subsequently, when you finalise the crop I believe the crop already includes the checkerboard part of the image only it's not shown correctly on the canvas in the Develop Persona but when you hit Develop the Photo Persona then correctly shows the crop including the checkerboard area...

If I mirror your rotation and crop in the Develop Persona I can't include as much of the upper windows as you do in your crop without the crop encroaching on the checkerboard area...

This also perhaps explains why I'm not seeing the issue at all having tried it around 30 times using the same image...

Notice how the top edge of the image doesn't remain perfectly horizontal when it's being rotated

[wlorentz]

On 12/28/2023 at 11:46 AM, Hangman said:

There appears to be something odd going on at the point where you rotate the image (28 secs)... if you look at the top edge of the image as you rotate it in your screen recording it always remains perfectly horizontal instead of rotating which is what I see when I rotate the image. I don't know if it's a screen redraw issue...

Subsequently, when you finalise the crop I believe the crop already includes the checkerboard part of the image only it's not shown correctly on the canvas in the Develop Persona but when you hit Develop the Photo Persona then correctly shows the crop including the checkerboard area...

If I mirror your rotation and crop in the Develop Persona I can't include as much of the upper windows as you do in your crop without the crop encroaching on the checkerboard area...

This also perhaps explains why I'm not seeing the issue at all having tried it around 30 times using the same image...

Notice how the top edge of the image doesn't remain perfectly horizontal when it's being rotated

 

 

You seem to be skipping a step in that screen recording.

You seem to set the crop and rotation, then go directly to pressing Develop.

When I get the corners cut off, I set the crop and rotation, then press [Enter] to commit the change, then press Develop.

 

[wlorentz]

On 12/28/2023 at 5:39 AM, Hangman said:

Is it unique to .cr2 files

It is not unique to Cannon raw files.  It also happens with my Sony raw files.  The image posted at the beginning of this thread is from a Sony camera.

[Hangman]

Hi @wlorentz,

Thanks for your reply... pressing Enter to commit the change prior to pressing Develop makes no difference for me...

It would be really helpful if you could perhaps upload a new screen recording that shows the process from a slightly earlier stage, i.e., from the point where you first add the crop and rotate the image and shows the full UI including any lens correction settings you make.

I'm keen to see if the rotate stage exhibits the same behaviour as seen in @NotMyFault's screen recording where the top of the image remains horizontal when rotated rather than rotating as it should...

Are you also able to upload your original ice cream RAW file so we can take a look at that as well...

[NotMyFault]

50 minutes ago, Hangman said:

screen recording where the top of the image remains horizontal when rotated rather than rotating as it should...

Hi,

this effect is only a temporary split-second issue. The video may exaggerate the effect due to 50 hertz sampling and video compression. It happens often when you hit develop (apply) that effects like lens correction become temporary invisible and get replaced by the unedited RAW image. I would suggest to keep this separate, meaning ignore it for now as it is not related to the cropping issue topic discussed in this thread. If you want to discuss that detail, it would be better to create a new thread to keep everything organized.

[Hangman]

Hi @NotMyFault,

The point I'm trying to make here is that the final crop you make in your screen recording where we see the bottom of the third set of windows simply isn't possible using the lens correction and rotation used without encroaching on the checkerboard background which is why I suspect this is a screen redraw issue...

Using the same image and the same settings I have to crop at the red line to avoid encroaching on the checkerboard background which then crops the bottom of the third set of windows completely out of the image as seen in the screen recording...

This is why the rotation is important because it looks to me as though the checkerboard isn't being shown where it should be in your screen recording and subsequently the crop is actually being made as per your finished cropped image which includes the checkerboard only at the point of rotation the screen is not being refreshed correctly and still shows the RAW image where it shouldn't.

[NotMyFault]

Agree that there are redraw issues. Never the less, in my perception the bug of this thread is not caused by or related to those redraw issues. 

Redraw issues could be overcome by changing zoom level, or inspect navigator panel (which can be enlarged to full screen size if panel is detouched) and/or layer thumbnails, or channels panel.

When combining lens correction (barrel distortion) with crop-in and rotation by crop, the crop gets misplaced after develop. This is new to V2.3 since the crop behavior changed to auto-crop to opaque areas (my assumption).

Affinity behaves very special when using linked RAW and barrel distortion and rotation  by crop. Only in this case, the edge areas impacted by barrel distortion get hidden after switching to Photo Persona, whereas cropped areas can be uncropped any time later.

But you can re-develop the RAW and recover those areas.

To see what I mean use move tool and unclip canvas.

 

[Hangman]

28 minutes ago, NotMyFault said:

When combining lens correction (barrel distortion) with crop-in and rotation by crop, the crop gets misplaced after develop. This is new to V2.3 since the crop behavior changed to auto-crop to opaque areas (my assumption).

I don't understand what you mean by " the crop gets misplaced after develop", could you elaborate a little...

28 minutes ago, NotMyFault said:

To see what I mean use move tool and unclip canvas.

Prior to unclipping the canvas I've added red guides to the four edges of the clipped image in the Photo Persona... The image below shows the unclipped image on the Left and the clipped Image on the Right... to me they look identical in terms of their crop but maybe I'm missing something obvious...

 

28 minutes ago, NotMyFault said:

Agree that there are redraw issues. Never the less, in my perception the bug of this thread is not caused by or related to those redraw issues. 

I may be completely wrong but I believe this is exactly what is causing the issue and subsequently causing the initial crop to be made incorrectly...

[NotMyFault]

A made a new bug report for iPad with a simplified setup.

Can you replicate the issue on Desktop?

Not sure if this thread covers the exact same issue.

 

[Hangman]

12 minutes ago, NotMyFault said:

A made a new bug report for iPad with a simplified setup.

Can you replicate the issue on Desktop?

I've just tried to replicate what you're seeing on Desktop and I'm unable to... I would suggest this is perhaps iPad specific but clearly @wlorentz is also using Desktop so I'm trying to figure out why I'm not able to replicate the issue...

The only obvious difference I can see on Desktop is the OS version, Sonoma vs Monterey so I'm unsure if there are two issues here, one specific to iPad and another specific to macOS version?

[wlorentz]

For what it's worth, this still happens in the current Affinity (2.6.3).

This is not merely a problem with the screen redrawing.  The saved/exported file also has the bad crop.

Watch the right edge of the tree in this video.  It is included in the photo after it is cropped, but before Develop is pressed.  It is removed after Develop is pressed.  

This is a raw file straight out of the camera.

The only changes that have been made are with the Basic sliders.

The image was cropped by pressing the C key, and rotated with the crop's control.

So what happened to the rest of the tree?  

This happens with Canon, Sony, and now Hasselblad files.  The issue persists through multiple operating system updates (currently on macOS Sequoia 15.5).  Clearly it's an Affinity issue, not an issue with any particular camera or file format.  I have attached the original file from the screen recording below.

 

1.CR2

 

[MEB]

Hi @wlorentz,
Thanks for your report. I’m getting the same output as you. Logging the issue to be looked into.
I've found some inaccuracies that I need to check with the dev team. Meanwhile, if you switch the RAW engine to Apple (Core Image RAW) in the Develop Assistant it should work as you'd expect and give an accurate preview of the crop.