Jump to content
larsbre

1.8.0.514 develop lens selector not working for manual lens

Recommended Posts

First of all, thanks for including the lens selector option in the develop persona. I really appreciate this tool and also like that you consider customer suggestions (not self-evident for every software company). However, I don't get the correct functionality for manual lenses like the Samyang 12mm f/2.0:

When I load my image, I can select the lens but no corrections are performed and there appears a yellow sign in the dialog box. Updating the settings does not lead to any action, as well.

Affinity.thumb.jpg.086e8226645076c7c39a42247753e980.jpg

I also included the name of the lens via exif-tool but this has no effect either.

Affinity_Exif.thumb.jpg.ab806fc918b47347e87be27f8a7ed145.jpg

 

I have attached the raw files that I used (...-Exif is the one with the lens added by exif-tool)

 

DSC08540.ARW

DSC08540-Exif.ARW

Share this post


Link to post
Share on other sites

Hi @larsbre,

For the lens correction to work, we would need a couple more arguments, not just -LensModel. 

exiftool -Lens="Samyang 12mm f/2.0 NCS CS" -LensModel="Samyang 12mm f/2.0 NCS CS" -ApertureValue="2.0" -FNumber="2.0" -FocalLength="12" FILENAME 

This should work on that specific Lens. I will pop an improvement in and see if we can work around this "issue" with manual lenses. 

However, modifying metadata can be dangerous/destructive (and we take no responsibility for the use of exiftool!)

Share this post


Link to post
Share on other sites
58 minutes ago, Gabe said:

For the lens correction to work, we would need a couple more arguments, not just -LensModel. 

I can see how that added information would be needed for automatic detection/selection of the lens by Photo, Gabe.

But shouldn't the user's manual selection of the lens from the list work no matter what the image EXIF data says?


-- Walt

Windows 10 Home, version 1909 (183623.476),
   Desktop: 16GB memory, Intel Core i7-6700K @ 4.00GHz, GeForce GTX 970
   Laptop:  8GB memory, Intel Core i7-3625QM @ 2.30GHz, Intel HD Graphics 4000 or NVIDIA GeForce GT 630M
Affinity Photo 1.7.3.481 and 1.8.0.532 Beta   / Affinity Designer 1.7.3.481 and 1.8.0.532 Beta  / Affinity Publisher 1.7.3.481 and 1.8.0.535 Beta

Share this post


Link to post
Share on other sites
16 minutes ago, walt.farrell said:

I can see how that added information would be needed for automatic detection/selection of the lens by Photo, Gabe.

But shouldn't the user's manual selection of the lens from the list work no matter what the image EXIF data says?

After determining the lens profile to use (be that automatically, or by manual selection), the resulting correction information still needs adjusting to account for focal length & aperture being different to when the correction data was generated.

Unfortunately, many fixed-focal-length lenses don't report that focal length to the camera, so the information is not in the image metadata. In those specific cases we can actually take it from the name of the lens instead, which we'll start doing in a future build (thanks for the report, @larsbre!).

A more general solution to missing metadata (e.g. when using a non-electronic zoom lens) would require sliders or similar in the Lens Correction panel.

Share this post


Link to post
Share on other sites
15 minutes ago, Tom Lachecki said:

After determining the lens profile to use (be that automatically, or by manual selection), the resulting correction information still needs adjusting to account for focal length & aperture being different to when the correction data was generated.

Thanks, Tom. That helps explain some aspects that weren't obvious to me.

Also, a somewhat belated "welcome to the Serif Affinity forums" :)


-- Walt

Windows 10 Home, version 1909 (183623.476),
   Desktop: 16GB memory, Intel Core i7-6700K @ 4.00GHz, GeForce GTX 970
   Laptop:  8GB memory, Intel Core i7-3625QM @ 2.30GHz, Intel HD Graphics 4000 or NVIDIA GeForce GT 630M
Affinity Photo 1.7.3.481 and 1.8.0.532 Beta   / Affinity Designer 1.7.3.481 and 1.8.0.532 Beta  / Affinity Publisher 1.7.3.481 and 1.8.0.535 Beta

Share this post


Link to post
Share on other sites

I agree with the comments above, the selector should give me full control in case of manual selection. Maybe for the automatic detection more data is required, but manual settings have to be independent from exif. I just used exiftool to give you some information to work with. Nevertheless, it seems to make progress. Good job guys, thank you for taking care!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×

Important Information

Please note the Annual Company Closure section in the Terms of Use. These are the Terms of Use you will be asked to agree to if you join the forum. | Privacy Policy | Guidelines | We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.