I know what you're talking about. I am aware of the non-destructive approach Serif chose for their cropping tools, which I think is quite useful. And while Adobe may use destructive cropping for crop to selection (I'm not positive), Serif doesn't have to implement the tool in the same manner.
Also,
- including this feature, even if destructive, would add functionality many users would care about (non-destructive cropping is nice, no doubt, but that's just icing on the cake. If the cake is missing, you don't want any icing?)
- The sample code I included would approach cropping to selection in a non-destructive manner, since it basically uses the already existing crop tool and enhances its spectrum of application.
Not renaming, but defining a different custom input for the tool and give that input a name.
It could be implemented as a cropping mode ("To Selection"?) for the current cropping tool.
Writing the last selected cropping mode as preference to disk would be nice as well. So you don't always have to change modes when you use one a lot.